Add GitHub actions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
0xNeshi
added a commit
that referenced
this pull request
Feb 8, 2022
4 tasks
6 tasks
SovereignAndrey
pushed a commit
that referenced
this pull request
Mar 17, 2022
…rresponding logic (#815) * Add AdditionalInformation page * Add button section * Add Form values and schema types * Add website field * Change website to description * Add org. name field * Move Button and InputRow to /common folder * Add fixed height to label part of InputRow * Add LogoInput * Refactor ButtonSections * Increase Loader width in ButtonSections * Add LogoInput to page * Create common RichTextEditor and add it to DescriptionInput * Move Editor-related components to EditorComponent * Refactor EditorComponent * Move editor logic init to useEditor hook * Switch Logo and Description positions * Update step 3 target endpoint on lambda * Enable step 4 submission * Update Dashboard step 4 status * Prepopulate charity overview * Remove min-h-10 from tailwind config * Remove comment from useSubmit * Rename RichEditor import in DescriptionInput to RichTextEditor * Add type to RichTextEditor * Add type guard to FileDropzone * Remove useCallbacks where EditorState is in deps array * Add CharityBanner input * Update image size validation * Add more valid image types * Change 'id' to 'htmlFor' in InputRow * Add CharityBanner to User type * Add 'getStepFour' logic for registration status * Add default values for step 3 * Remove image formats not supported by all browswers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I've currently opened this PR against the
issue1branch asmainis currently empty.I believe it makes sense to merge
issue1intomainfirst, then to merge this PR againstmainto ensure each PR is as small as it can be (and therefore will be directionally easier to review).Once the branch
issue1has been merged in, we can install Prettier and run it locally before rebasing this branch to ensure CI is in a green state.Prettierfor automatic code formattingESlintand associated documentationterra.js(Note: there is an outstanding issue here, need to determine if it is in how the wallet provider is being used, or whether it is in a third party dependency)Create-React-App comes with
ESlintout of the box, so this PR adds a command to take advantage of that and also installsPrettierto help format code programmatically and in-editor.It also adds a GitHub action to lint, and to test the codebase when commits are pushed. For now, these are configured as seperate
jobsmeaning they run independently.The advantage of this is that if tests fail, the linter will still be ran and vice versa - this means anyone working on the repo will have much more granular feedback (e.g. a linting error does not prevent you from knowing whether your tests worked in CI).
The downside is this uses more automation minutes for the repo (3k, or 50k depending on your plan).
If you feel sensitive to how many minutes are used, I'd combine them into a single job but for now believe you are best served by running them in parallel.
To start using this, I recommend adding branch protection to
main: to stop anyone from pushing directly tomain, and to ensure status checks pass before a PR can be merged intomain.This will help ensure
mainis always green, and ready to deploy.